Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Update dependencies #197

Closed

Conversation

timnoorlander
Copy link
Contributor

Description

Please provide a short summary explaining what this PR is about.

Fixes # (issue)

How to test?

Please provide a short summary how your changes can be tested?

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@timnoorlander timnoorlander requested a review from a team as a code owner April 26, 2023 12:23
shpomp
shpomp previously approved these changes Apr 26, 2023
@shpomp
Copy link
Contributor

shpomp commented May 1, 2023

I followed this storybookjs/storybook#18923
And then migration guides
https://github.com/storybookjs/storybook/blob/4a532ec8d8922ddf6b7a7e1cc68d88b35377b0a6/MIGRATION.md#start-storybook--build-storybook-binaries-removed
https://storybook.js.org/docs/react/migration-guide#page-top
I fixed Storybook itself, but now I broke something in a different way 😿 (something babel)

Since we will not use Storybook in class23 FP, I suggest we leave this (resolve it on the side) and move onto our own repo (with Storybook removed) @timnoorlander 🙏🏽

@shpomp shpomp closed this Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants