-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled time does not have aria-disabled attribute (unlike disabled dates) #4259
Closed
alexkuc opened this issue
Sep 15, 2023
· 3 comments
· Fixed by qburst/react-datepicker-3#5, #4319 or jones58/personal-knowledge-wiki#29 · May be fixed by rowidanagah/EduMentorMate#9
Closed
Disabled time does not have aria-disabled attribute (unlike disabled dates) #4259
alexkuc opened this issue
Sep 15, 2023
· 3 comments
· Fixed by qburst/react-datepicker-3#5, #4319 or jones58/personal-knowledge-wiki#29 · May be fixed by rowidanagah/EduMentorMate#9
Comments
If my understanding is correct, we only need to add aria attribute here: Lines 208 to 210 in 9c24960
If this sounds right, I can submit a PR for this. |
Go ahead, I can review a PR |
balajis-qb
pushed a commit
to qburst/react-datepicker-3
that referenced
this issue
Oct 14, 2023
Moved the logic to find whether a time is disabled logic to a helper method to reuse the logic both for the add of react-datepicker__time-list-item--disabled class ans also for the add of aria-disabled attribute Closes Hacker0x01#4259
balajis-qb
pushed a commit
to qburst/react-datepicker-3
that referenced
this issue
Oct 14, 2023
…Time component Ensure the test cases to accurately check for the presence of 'aria-disabled' attribute in the Time component when it's disabled Closes Hacker0x01#4259
This was referenced Oct 14, 2023
Hi @martijnrusschen, |
martijnrusschen
added a commit
that referenced
this issue
Oct 15, 2023
…-for-Time-component Fix #4259: Add the aria-disabled on the Time component's disabled time units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When certain time is excluded, it does not have aria attribute
aria-disabled
unlike disabled datesTo Reproduce
Steps to reproduce the behavior:
Time
column using Chrome's dev toolsExpected behavior
See attribute
aria-disabled="true"
present for both, disabled dates and disabled times.The text was updated successfully, but these errors were encountered: