Fix #4317: Fix Enzyme Test file in exclude_times_test.js and migrate it to use @testing-library/react #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2023 22:19
In the exclude_times_test.js file, the following modifications were made to improve the test case:
1. Added the 'open' prop to the <DatePicker /> component to ensure that it is open and its children can be tested.
2. Corrected the call to 'setTime' by providing the correct parameter format, { hour: x, minute: x }, instead of { hours: x, minutes: x }.
3. Replaced the assertion using '.not.toBeNull()' with '.toHaveLength(4)' when using '.find()'. This change makes the assertion more specific and reliable, ensuring that the test case passes only when it should.
These updates enhance the accuracy and reliability of the test case in the exclude_times_test.js file.
Closes Hacker0x01#4317
This commit updates the test case in exclude_times_test.js from using Enzyme to using @testing-library/react as requested by @martijnrusschen on [the issue Hacker0x01#4317](Hacker0x01#4317 (comment))
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## main #4318 +/- ##
==========================================
+ Coverage 96.54% 96.63% +0.08%
==========================================
Files 27 27
Lines 2374 2374
Branches 966 966
==========================================
+ Hits 2292 2294 +2
+ Misses 82 80 -2 |
|
Nice that was quick! looking great :) We have more usage of Enzyme, if you're up feel free to remove those as well. We need to remove Enzyme before we can safely migrate to the React 18 render methods. |
|
More info can be found here: #4300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4317
Summary
This PR addresses the issues in the test file
exclude_times_test.jsand also migrated the test cases to use@testing-library/reactinstead ofenzymeas requested by @martijnrusschenChanges Made
setTimecall<DatePicker />component to test it, by passing theopenprop.toHaveLength(4)instead of using.not.toBeNull@testing-library/react