Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): PropsWithChildren type argument issue #5236

Merged

Conversation

mertJF
Copy link
Contributor

@mertJF mertJF commented Nov 18, 2024

Problem
The current CalendarProps type definition is incorrect, leading to type errors when using the component. This issue arises because React.PropsWithChildren is a generic type that requires a type argument to specify the component's props.

Same as: #5223

Changes
This PR fixes the type definition by correctly combining React.PropsWithChildren with CalendarProps. This ensures proper type checking and prevents potential runtime errors.

Screenshots

error

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@mertJF you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 8
- 4

100% TSX

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (65bcb7e) to head (c7a151e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5236   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          29       29           
  Lines        3381     3381           
  Branches     1414     1401   -13     
=======================================
  Hits         3276     3276           
- Misses        103      105    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to combine React.PropsWithChildren with CalendarProps looks good and appears that it will resolve the issue noted in the PR description. I don't have any blocking concerns.

Image of Jonah Jonah


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit f26e907 into Hacker0x01:main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants