fix(types): PropsWithChildren
type argument issue
#5236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current CalendarProps type definition is incorrect, leading to type errors when using the component. This issue arises because
React.PropsWithChildren
is a generic type that requires a type argument to specify the component's props.Same as: #5223
Changes
This PR fixes the type definition by correctly combining
React.PropsWithChildren
withCalendarProps
. This ensures proper type checking and prevents potential runtime errors.Screenshots
Contribution checklist