Add Auto-Compile code to test F3DEX3, STILL W.I.P, NEED TO FIND OUT HOW TO ZIP THE BINARIES #8
Conversation
.github/workflows/makefile.yml
Outdated
| - name: Get armips | ||
| run: git clone --recursive https://github.com/Kingcom/armips.git ; cd armips ; mkdir build && cd build ; cmake -DCMAKE_BUILD_TYPE=Release .. ; cmake --build . ; sudo cp armips /usr/bin |
There was a problem hiding this comment.
you can replace with
- name: Get armips
uses: actions/checkout@v4.1.1
with:
path: armips
repository: Kingcom/armips
submodules: "true"
run: |
cd armips
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
cmake --build .
There was a problem hiding this comment.
yeah so i tried to use this code and it didn't work
Makefile
Outdated
| doc: | ||
| doxygen Doxyfile |
There was a problem hiding this comment.
it caused compilation errors when trying to compile f3dex3
There was a problem hiding this comment.
it's because it's two space and not a true tabulation so if you replace it with a tabulation it will no longer make the error
.github/workflows/makefile.yml
Outdated
| run: git clone --recursive https://github.com/Kingcom/armips.git ; cd armips ; mkdir build && cd build ; cmake -DCMAKE_BUILD_TYPE=Release .. ; cmake --build . ; sudo cp armips /usr/bin | ||
|
|
||
| - name: Make The Binary | ||
| run: make -j |
There was a problem hiding this comment.
why not just make -j ARMIPS=armips/build/armips it will work without needed to copy it in /usr/bin
|
why the last two don't detect I guess it's because of space you have so try with this jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install dependencies
run: sudo apt install cmake build-essential
- name: Get armips
uses: actions/checkout@v4.1.1
with:
path: armips
repository: Kingcom/armips
submodules: "true"
run: |
cd armips
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
cmake --build .
- name: Make The Binary
run: make -j ARMIPS=armips/build/armips |
now when ever i copy it EVERYTHING says missing required root key on |
|
hmm 2 sec I will try on my fork |
|
and for the zip of binaire I know how to do it but like f3dex3 are on a grey zone because it's use f3dex2 like base who are proprietary any bin will be distrubuate directly |
|
I make a PR to you fork who fix all thing I say https://github.com/ThePerfectLuigi64/F3DEX3/pull/2/ |
Merge coco's fixes
|
(for binairie you can use this https://github.com/actions/upload-artifact but like I mention earlier F3DEX3 are in zone where publish bin of it can be a legal issue) |
| path: build | ||
| # The desired behavior if no files are found using the provided path. | ||
| retention-days: 0 | ||
| compression-level: 0 |
There was a problem hiding this comment.
need two space for the tabulation
| - name: Upload a Build Artifact | ||
| uses: actions/upload-artifact@v4.3.3 | ||
| with: | ||
| # A file, directory or wildcard pattern that describes what to upload | ||
| path: build | ||
| # The desired behavior if no files are found using the provided path. | ||
| retention-days: 0 | ||
| compression-level: 0 |
There was a problem hiding this comment.
like I mention this can make legal issue to post F3DEX3 binairie
There was a problem hiding this comment.
the fact that you can compile f3dex3 with just a make and it has copyrighted code IN, THE, FILES, and that's fine but binary ohhhh noooo so scary, it really doesn't matter
There was a problem hiding this comment.
I just related a recent conversation about how we should include f3dex3 in hackeroot and hackersm64 in hackern64 discord. And Sauraen was thinking to include it as submodule where the binary are compiled but not included the binary file.
There was a problem hiding this comment.
It is the community's official position that reverse engineered source code, including assembly, does not fall under the same copyright as the original copyrighted binary, or is entitled to fair use protections which would not apply to just distributing the binary. Since this is a project under the HackerN64 org, it needs to follow their standards about this.
I also don't think there's much value in distributing the artifacts. It's not like a tool where we want to make it easy for people to download and get started with limited technical ability. The only people who will want the binaries here are romhack developers, and they will at the minimum have to modify their project's build system (and game engine code) to use F3DEX3, so it's not much of an extra burden for them to have to build the microcode from source. If someone wants to make a project with minimal setup, they should use HackerOoT or HackerSM64 which already have F3DEX3 built in.
The other changes besides this, which coco already moved to a separate PR, are good and I will merge them, thanks!
No description provided.