This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Update URL and projects list based on langauge query parameter #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Uses work I did in: #270 (obsolete- will be closed).
Started this new branch off of latest master.
My work lives in
language_filter.js
since I needed to reference functions in the filter file.Note: Redis was not working on my machine, so I used the
db/seed.rb
file to generate fake issues for the projects section. Onlybrainfuck
language choice has fake issues created for it. You can manually change which language generates fake issues in the seed file or use redis on your machine for testing with real data. Any language that does not have fake issues will simply not show any projects (but the language selection and updated project text still function)Functionality
Additional functionality:
This was not asked for - but I felt it was important/necessary for UX:
I added the ability to update the URL if a user clicks a new language from the language dropdown
There is now functionality to remove the query from the URL if a user clicks the "remove filter" button (i.e.
localhost:3000/?language=python
tolocalhost:3000
)URLs can now be copied and pasted into new tabs/windows and the query parameter will still function (page scrolls to the issues section and filters the projects based on the queried language)