Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input device refactoring #89

Merged
merged 18 commits into from
Oct 10, 2024
Merged

Input device refactoring #89

merged 18 commits into from
Oct 10, 2024

Conversation

HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Oct 8, 2024 •
edited
Loading

Current implementation binds matrix in keyboard, makes it difficult to add other input devices like rotary encoder, touchpad, etc. We have to add all types of input device to keyboard like matrix and poll them in the scanning loop.

This PR decouples matrix and keyboard, enables add other input devices as a separate task too.

Closes #71
Closes #75

HaoboGu added 13 commits October 6, 2024 17:50
@HaoboGu
feat(core): add input device trait
1dfefab 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(core): add activated layer getter
ae20caa 
Signed-off-by: HaoboGu <haobogu@outlook.com>
@HaoboGu
feat(core): experimental impl of decoupling matrix and keyboard
ae5497a 
Signed-off-by: HaoboGu <haobogu@outlook.com>
@HaoboGu
refactor(core): decouple matrix and keyboard
d602bcb 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
doc: update device doc
2a36071 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Merge branch 'main' into feat/input_device
c6c9d6b
@HaoboGu
refactor(core): use crate-level static channels
707e621 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(core): add row2col key event sending
b4a026f 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(core): tap hold rework for decoupled keyboard
b74b646 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(split): decouple split matrix and key process
1ff1fcc 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(core): use a single usb keyboard task
bbcdaf8 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(core): use key event when processing key, add mouse key proc…
eb7ce7e 
…essing

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(core): remove input_device trait
df6705a 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Owner Author

HaoboGu commented Oct 9, 2024 •
edited
Loading

To be tested:

  • esp32
  • nrf52840
  • stm32
  • nrf52840 split
  • layer key, layer cache
  • mouse key, multiple mouse key (>= 4
  • tap hold

@HaoboGu HaoboGu marked this pull request as ready for review October 9, 2024 14:59
@HaoboGu
refactor(core): remove keyboard_task, use keyboard.run()
09f99f1 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix(esp): increase esp main stack size
d5b6872 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
chore(esp): update used esp-idf version
97d1004 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
doc: update documents
41d6e9b 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
chore: update lock files
80ae740 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu merged commit 48b788a into main Oct 10, 2024
0 of 2 checks passed
@HaoboGu HaoboGu deleted the feat/input_device branch October 10, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async memory usage Keyboard code changes tracking
1 participant
@HaoboGu