Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct prefix for build and ci dependencies #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kayman-mk
Copy link
Member

@kayman-mk kayman-mk commented Dec 20, 2024

Description

  • use ci prefix for the release process defined in .release
  • use build prefix for Maven and related plugins
  • use the correct prefix for dependencies used in the dependencyManagement section

Verification

Not checked

Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@kayman-mk
Copy link
Member Author

Seems that the Json check does not work for Json5 files.

Edit: addressed in Hapag-Lloyd/Workflow-Templates#148

@kayman-mk kayman-mk marked this pull request as ready for review December 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant