Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPStan errors for level 3 #213

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

peter-gribanov
Copy link
Member

@peter-gribanov peter-gribanov commented Oct 24, 2019

Line BaseSpecification.php
41 Method Happyr\DoctrineSpecification\BaseSpecification::getFilter() should return string but empty return statement found.
63 Method Happyr\DoctrineSpecification\BaseSpecification::getSpec() should return
Happyr\DoctrineSpecification\Filter\Filter|Happyr\DoctrineSpecification\Query\QueryModifier but empty return statement found.
Line Spec.php
121 Method Happyr\DoctrineSpecification\Spec::andX() should return Happyr\DoctrineSpecification\Logic\AndX but returns object.
132 Method Happyr\DoctrineSpecification\Spec::orX() should return Happyr\DoctrineSpecification\Logic\OrX but returns object.
Line Specification/Having.php
52 Method Happyr\DoctrineSpecification\Specification\Having::getFilter() should return string but empty return statement found.
Line EntitySpecificationRepositoryTrait.php (in context of class Happyr\DoctrineSpecification\EntitySpecificationRepository)
162 Return type (Generator&iterable) of method Happyr\DoctrineSpecification\EntitySpecificationRepository::iterate() should be compatible with return type (array) of method Happyr\DoctrineSpecification\EntitySpecificationRepositoryInterface::iterate()

@peter-gribanov peter-gribanov self-assigned this Oct 24, 2019
@peter-gribanov peter-gribanov added this to the Release 1.1.0 milestone Oct 24, 2019
@peter-gribanov peter-gribanov merged commit ab379f6 into Happyr:master Oct 24, 2019
@peter-gribanov peter-gribanov deleted the phpstan_level_3 branch October 24, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant