Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan errors for level 5 #215

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix PHPStan errors for level 5 #215

merged 2 commits into from
Oct 25, 2019

Conversation

peter-gribanov
Copy link
Member

@peter-gribanov peter-gribanov commented Oct 24, 2019 •
edited
Loading

Line Result/RoundDateTime.php
38 Parameter # 1 $unixtimestamp of method DateTimeImmutable::setTimestamp() expects int, float given.
Line EntitySpecificationRepositoryTrait.php (in context of class Happyr\DoctrineSpecification\EntitySpecificationRepository)
202 Result of && is always false.
207 Else branch is unreachable because ternary operator condition is always true.

phpstan/phpstan#2538

@peter-gribanov peter-gribanov self-assigned this Oct 24, 2019
@peter-gribanov peter-gribanov added this to the Release 1.1.0 milestone Oct 24, 2019
@peter-gribanov peter-gribanov changed the title $unixtimestamp of method DateTimeImmutable::setTimestamp() expects int, float given Fix PHPStan errors for level 5 Oct 24, 2019
@peter-gribanov peter-gribanov merged commit 137170b into Happyr:master Oct 25, 2019
@peter-gribanov peter-gribanov deleted the phpstan_level_5 branch October 25, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peter-gribanov peter-gribanov

Labels
bug
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@peter-gribanov