Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from GitHub CI #255

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

peter-gribanov
Copy link
Member

Do changes from #250 for master.

@peter-gribanov peter-gribanov self-assigned this Dec 3, 2020
@peter-gribanov peter-gribanov added this to the Release 1.1.2 milestone Dec 3, 2020
@peter-gribanov peter-gribanov reopened this Dec 3, 2020
@peter-gribanov peter-gribanov changed the title Build from GitHab CI Build from GitHub CI Dec 3, 2020
@peter-gribanov
Copy link
Member Author

peter-gribanov commented Dec 3, 2020

continuous-integration/travis-ci Expected — Waiting for status to be reported

@Nyholm this job is stuck. It looks like this a Branch protection rule setting prohibits merging branches without a positive response from Travis CI, which we refuse in this request. Can you check this?

@Nyholm
Copy link
Member

Nyholm commented Dec 7, 2020

I thought I've answered this. Im sorry.

I've updated the branch protection now

@Nyholm
Copy link
Member

Nyholm commented Dec 7, 2020

You may now update the branch protection rules yourself if you want to

@peter-gribanov peter-gribanov merged commit ade3b3d into Happyr:master Dec 7, 2020
@peter-gribanov
Copy link
Member Author

@Nyholm thanks

@peter-gribanov peter-gribanov deleted the github_ci_1.1 branch December 7, 2020 16:51
@peter-gribanov
Copy link
Member Author

peter-gribanov commented Dec 7, 2020

You may now update the branch protection rules yourself if you want to

@Nyholm branch protection rules are available in the project settings, which i do not have access to now. I don't really need the project settings. Although you still have to manage the list of checkers. We need to change the list of checkers for version 1.1 and we will need to change the list of checks after release 2.0. At the end of 2021, i would plan to abandon PHP 7.3, add support for PHP 8.1 and a new major release with a change in the list of checkers.

image

@peter-gribanov peter-gribanov restored the github_ci_1.1 branch December 10, 2020 15:40
@peter-gribanov peter-gribanov deleted the github_ci_1.1 branch December 10, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants