Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-auth-backend-oauth2: map additional_scopes_key to extra_scop… #1

Closed
wants to merge 2 commits into from

Conversation

Hathoute
Copy link
Owner

@Hathoute Hathoute commented Nov 18, 2024

Proposed Changes

Fix rabbitmq#12750 by introducing a synonyms map that will map additional_scopes_key to extra_scopes_source, instead of replacing extra_scopes_source in the schema which will be a breaking change.

There's probably a better way to handle this, as this is my first time writing erlang code, let me know what you think.

Types of Changes

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes (tested only rabbitmq-auth-backend-oauth2)

@Hathoute Hathoute force-pushed the map-resource-server-additional-scopes branch 3 times, most recently from 358f407 to 823f783 Compare November 18, 2024 17:07
@Hathoute Hathoute force-pushed the map-resource-server-additional-scopes branch from 823f783 to 0d799a5 Compare November 18, 2024 17:08
@Hathoute Hathoute closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'additional_scopes_key' ignored when configuring multiple oauth2 resource servers
1 participant