Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a small issue with android config on lime 8.2.0. #3253

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

MAJigsaw77
Copy link
Contributor

@MAJigsaw77 MAJigsaw77 commented Sep 18, 2024

This PR fixes a small were it adds if="android" on the outputed AndroidManifest.xml on lime (8.2.0).
asd

@Geokureli
Copy link
Member

Geokureli commented Sep 19, 2024

I'm not familiar with what <config:android> does, and why if="android" is bad here, please elaborate

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Sep 19, 2024

I'm not familiar with what <config:android> does, and why if="android" is bad here, please elaborate

lime doesn't check for conditions when doing

<config:android>
	<application android:appCategory="game" if="${lime &ge; 8.2.0}" />
</config:android>

It adds up everything within the config:android section to the android manifest.

@MAJigsaw77
Copy link
Contributor Author

When i did that pr 8 months ago i haven't thought about that until i tried lime 8.2.0 myself ;--;

@Geokureli
Copy link
Member

Geokureli commented Sep 19, 2024

Did you verify that this change works with lime versions earlier than 8.2.0? it seems like it would behave the same as before, but I'd like to double check, since flixel supports lime 8.0.2 at the minimum, and we don't test android in CI (or minimum versions, yet)

@MAJigsaw77
Copy link
Contributor Author

Did you verify that this change works with lime versions earlier than 8.2.0? it seems like it would behave the same as before, but I'd like to double check, since flixel supports lime 8.0.2 at the minimum, and we don't test android in CI (or minimum versions, yet)

This section can only accure if lime is 8.2.0 or later.

<section if="${lime >= 8.2.0}">
	<config:android>
		<application android:appCategory="game" />
	</config:android>
</section>

These changes have been tested in here https://github.com/FunkinDroidTeam/flixel/blob/logVolume/include.xml and this is the compiled build were the changes have been tested on https://github.com/FunkinDroidTeam/Funkin/actions/runs/10947527345.

@Geokureli Geokureli merged commit 4b05488 into HaxeFlixel:dev Sep 19, 2024
11 checks passed
@Geokureli
Copy link
Member

Thanks!

@MAJigsaw77 MAJigsaw77 deleted the patch-1 branch September 19, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants