add broadcast ability to udp sockets #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I see this correctly, the build failure on windows is unrelated to this PR. Seems like openal cannot be installed on windows. I don't understand what is going on, but I assume the CI would need to be force-rerun at some point (assuming it's the fault of openal) |
crazyjul
pushed a commit
to playdigious/hashlink
that referenced
this pull request
Jan 18, 2024
* add broadcast ability to udp sockets * rename variable 'fast' to 'broadcast' * Update socket.c --------- Co-authored-by: Chris Rutenkolk <chris.rutenkolk@hhu.de> Co-authored-by: Simon Krajewski <simon@haxe.org>
RandomityGuy
pushed a commit
to RandomityGuy/hashlink
that referenced
this pull request
Jun 1, 2024
* add broadcast ability to udp sockets * rename variable 'fast' to 'broadcast' * Update socket.c --------- Co-authored-by: Chris Rutenkolk <chris.rutenkolk@hhu.de> Co-authored-by: Simon Krajewski <simon@haxe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Trying out heaps.io, I noticed, that the implementation for sockets was missing the
setBroadcastfunction for udp.I hope I implemented this correctly as it isn't a big diff.
I tested sending broadcasts with ubuntu 20.04, haxe 4.1.4, heaps 1.8.0
They showed up in wireshark and I could recieve them on another machine in the same network.