when doing safe_cast on HVIRTUAL, ignore extra fields from input type #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and just make sure all expected fields are present
|
Problem fixed in Haxe HaxeFoundation/haxe#11723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure this does not break anything else, but what i am attempting here is to solve the issue where interfaces that extends other interfaces and override a method signature by changing its return type ends up corrupting something making the runtime call a different unrelated method.
this fixes the interface-wrong method issue (#685).
Note that it does not fix the Access Violation you get from typedef example, however they seem to be related, if i on purpose set hl_vfields(v)[i] to the method reference instead of NULL when hl_safe_cast returns false in hl_to_virtual, the typedef variant runs just fine as well.