[hlc] Speed up hlc visual studio templates #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the %(Filename) variable is unique for each compiled file, this resulted in a separate cl.exe invocation for each file. This makes us unable to make use of /MP to speed up cl.exe. We can instead simply pass the directory and the file name will be added to the end automatically. This still means that there is a separate cl.exe invocation per directory, however, this is much faster already. The %(RelativeDir) must remain otherwise all object files are placed in a single directory. This would be a problem if two files share a name.
tobil4sk
changed the title
GlassySundew
pushed a commit
to GlassySundew/hashlink
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each file requires a separate cl.exe invocation. This PR reduces the number of cl.exe invocations needed to build the project by allowing multiple files to be compiled in the same cl.exe invocation (by passing object output directory instead of object output file name, which means more files share the same compilation arguments). This already gives a noticeable speed up.
It further improves the speed by enabling multi processor compilation, which is possible now that the same cl.exe invocation deals with multiple files.
As an example, on my machine with the HelloWorld program in
other/tests, compilation speed goes from 18.6 seconds to 7.3 seconds.Further speed up is possible if
/Fois removed from the cl.exe invocation altogether (since then all files can be compiled in one invocation). However, this would cause issues if files in different directories share a name, since by defaultcl.exeputs all object files in the same directory.