Clean up field-level errors #10896
Merged
Clean up field-level errors #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If hxcpp tests are fine with that change, should be fine :D It was added a while ago because hxcpp needed a more recent utest version, but seems like it's using a correct version now even without this. Nice change, even if it will make updating my error reporting PR painful :D |
kLabz
approved these changes
Dec 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into fixing #10881 and then one thing led to another because the inconsistencies of the error messages annoyed me. This isn't perfect yet but should be better than what we currently have.
See
.stderrdiff for what actually changed, although not all these changes are captured by our tests.@kLabz I've changed the hardcoded git reference to utest because that was still causing me problems. Is it alright to do that? I forget why this was there in the first place.