-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lua] Remove haxe-deps and directly reference dependencies; re-enable CI #10916
Conversation
Respect lua-vanilla for Json.parse
fix typo
This test fails on Lua (returns 0)
Nice! And wow, they actually still pass, that's a nice surprise. In the long run, we should still sort out the haxe-deps situation, but for now this is a very welcome addition. Thank you! |
Thank you.
If we are to switch back to haxe-deps, I recommend we take it over and have that luarock be sourced from this repo (not a separate one). That said, I am not sure we really need something like haxe-deps even if it is sort of useful from a user perspective. |
What is Haxe-deps?
El sáb., 25 mar. 2023 14:09, Uzume ***@***.***> escribió:
… Thank you.
Nice! And wow, they actually still pass, that's a nice surprise. In the
long run, we should still sort out the haxe-deps situation, but for now
this is a very welcome addition. Thank you!
If we are to switch back to haxe-deps, I recommend we take it over and
have that luarock be sourced from this repo (not a separate one). That
said, I am not sure we really need something like haxe-deps even if it is
sort of useful from a user perspective.
—
Reply to this email directly, view it on GitHub
<#10916 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWKOIHPHSRFMRBKWBODW53U6ZANCNFSM6AAAAAATQGHP34>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@danielo515: haxe-deps or jdonaldson/haxe-deps is an apparently unmaintained LuaRocks package that contained nothing but dependencies necessary for Haxe. At some point we switched to using that to ensure all the Lua dependencies for Haxe were installed (and it is handy for user installs), however, is has not been maintained/updated so now it is only deceptive. I meant by my statement that if we go back to something like haxe-deps then it should be owned and maintained by this repo and not some random third-party. That way it can be kept up-to-date with the code that actually needs/uses it (since it lives in the same place). |
This removes the abandoned haxe-deps LuaRocks reference for lua tests.
While we could have forked it, it is more secure to just directly reference the dependencies (avoiding a supply chain attack, similar to those that have happened on nodejs package managers before).
This resolves #10777 and #5024, and skips unit test Issue10752 (#10752) for Lua, and re-enables CI tests for Lua