-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eval] Migrate to pcre2 #11032
[eval] Migrate to pcre2 #11032
Conversation
Now is mostly up to date with the old pcre-ocaml, aside from some patches that don't work on ocaml 4.07.1: mmottl/pcre-ocaml@b3a998c mmottl/pcre-ocaml@24cb157 mmottl/pcre-ocaml@5cd2396
Fixes builds on Ubuntu 18.04
Oh shit, CI is actually green...! I'll quickly merge this before it changes its mind. Thank you so much, this has certainly been on my personal "Oh God not that problem"-backlog. |
@tobil4sk Great work! Are you going to look at hxcpp next? Maybe I will try to take tobil4sk/pcre2-ocaml and work it into a PR at mmottl/pcre-ocaml or something and try to get it introduced into opam. There are many dependencies on opam - pcre that would do well to be ported to pcre2. I know many distributions (like Debian and Ubuntu, etc.) that want to drop pcre1 packages (like the confusingly named pcre3) but there is still too much software that depends on them and this might go a long ways towards helping that situation. |
@Uzume Yes, I'll make a PR soon. I've ported our code, but there are still some building issues that have to be resolved.
The author of pcre-ocaml has said he thinks pcre2-ocaml should be kept separate, but we can upload prce2 as a new opam package. There are still a few things that are missing (namely jit compilation) which we didn't need for Haxe but which would have to be implemented before the library is ready more generally. If you like, feel free to open an issue in pcre2-ocaml and we can discuss further over there. |
@tobil4sk: Yes, I am aware of that. I was just thinking to create a branch in the original repo for pcre-ocaml and move the default master branch over to pcre2-ocaml (or something similar). It makes little sense to consider maintenance for these in entirely different repos when a separate branch should suffice. |
I don't think that |
Hm, could be related to #11012 |
Closes #10491
I rewrote the existing ocaml pcre bindings for pcre2. I also uploaded them here: https://github.com/tobil4sk/pcre2-ocaml, but the version in this PR is slightly modified for compatibility with the OCaml version used by Haxe.
This addresses the null byte in regex bug as well: #10592