Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behaviour of Optimize Import #191

Closed
boozook opened this issue Mar 30, 2015 · 13 comments
Closed

Wrong behaviour of Optimize Import #191

boozook opened this issue Mar 30, 2015 · 13 comments
Labels

Comments

@boozook
Copy link

boozook commented Mar 30, 2015

Build: Build 0.8.1.1.TiVo.4

Need to filtering similar import-items. In my demo I did copy-paste and get a dialog with many of the same items. After it I was try to Optimize Imports - get no wanted result :(

haxe plugin issue mov opt

@as3boyan
Copy link
Contributor

Ok, CopyPasteProcessor doesn't checks for duplicate items and Optimize imports doesn't detects duplicate imports. Thanks.

@as3boyan
Copy link
Contributor

I'm curious is this an IDEA 14?

@as3boyan
Copy link
Contributor

Ok, roger that

@boozook
Copy link
Author

boozook commented Mar 30, 2015

Yes, latest Idea 14.

On 30 Mar 2015, at 19:24, as3boyan notifications@github.com wrote:

I'm curious is this an IDEA 14?


Reply to this email directly or view it on GitHub.

@as3boyan
Copy link
Contributor

I added a check for duplicate items(CopyPasteProcessor), about Optimizing imports - can't reproduce it, for flash.display.Sprite it works fine, it may not work if reference is unresolved, but it seems to be resolved on your gif.

@as3boyan
Copy link
Contributor

Please try to optimize this:

import flash.display.Sprite;
import flash.display.Sprite;
import flash.display.Sprite;

@boozook
Copy link
Author

boozook commented Mar 31, 2015

Magic! It works but how?!
I can reproduce this issue only in that project: https://bitbucket.org/fzzr/hx.signal/.....

screen shot 2015-03-31 at 21 11 42

@as3boyan
Copy link
Contributor

as3boyan commented Apr 2, 2015

Is that specific commit or I can download just latest develop branch from downloads section?

@boozook
Copy link
Author

boozook commented Apr 2, 2015

Take the last commit. (latest)

@boozook
Copy link
Author

boozook commented Apr 3, 2015

@as3boyan
That's new:
screen shot 2015-04-04 at 1 21 35

Maybe related issues: #199 & #200.

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

Seems like this doesn't works

import String.fromCharCode in f;

class Main2 {
    static function main() {
        var c1 = f(65);
        var c2 = f(66);
        trace(c1 + c2); // AB
    }
}

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

I think it doesn't supported yet.

as3boyan added a commit that referenced this issue Apr 4, 2015
as3boyan added a commit that referenced this issue Apr 8, 2015
…ions

Resolve static function imports for import with in keyword (import String.fromCharCode in f;) #191
@EBatTiVo
Copy link
Contributor

Appears fixed and merged. @fzzr- Please test and re-open if this bug is not fixed.

@EBatTiVo EBatTiVo added the bug label Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants