Fix pcre memory leak #262
Merged
Fix pcre memory leak #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context is not needed as the default depth limit is fine. Since pcre 10.30, pcre2_match no longer uses recursive function calls, so this setting should no longer be needed.
andyli
pushed a commit
that referenced
this pull request
Jul 4, 2023
* Fix memory leak The context is not needed as the default depth limit is fine. Since pcre 10.30, pcre2_match no longer uses recursive function calls, so this setting should no longer be needed. * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was technically a memory leak introduced in #249, although, the structure was allocated once and required throughout the lifetime of the program. However, the context is not really needed at all anymore. Since pcre 10.30, pcre2_match no longer uses recursive function calls, so this setting should no longer be needed.
See HaxeFoundation/hashlink/pull/515
This also fixes: HaxeFoundation/haxe#8829