Fix "GetThreadContext failed" on Windows #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to get the fix for the GetThreadContext error on Windows. ivmai/bdwgc@449eda0
Enabling parallel marking causes an error. https://github.com/ivmai/bdwgc/blob/v7.6.16/win32_threads.c#L175 The reason this wasn't an issue before, is that in the version of bdwgc that we were previously using, enable_parallel_mark didn't actually have the intended effect. That was fixed in bdwgc 7.6.2. ivmai/bdwgc@d66bd58
|
For reference, here are some more details about the build changes: ivmai/bdwgc#452 We might want to consider moving to 8.2 as suggested, because that way we can be more specific about what options we turn off. So long as there aren't any more build issues, of course. |
Ubuntu 20.04 still has 7.6 so there is probably no point in doing this, especially with the potential breaking changes that come with a major version upgrade. The azure pipelines error should have been resolved in master, so updating and solving the merge conflicts should fix the errors. |
|
Pushed an update to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of bdwgc that Neko uses (7.6.0) can suddenly abort when GetThreadContext is called, if the thread is in protected code or an invalid state. One of the common culprits of this issue is antivirus programs.
This was fixed by Unity a few years ago, and included in the upstream 7.6 release line for 7.6.14.
This PR updates us to the latest bdwgc 7.6 release, 7.6.16.
Special thanks to @tobil4sk for helping resolve issues updating to the latest version.