Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed dependency on Foundation #22

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

bradhowes
Copy link
Contributor

Description

Addresses issue #13

Removes Foundation dependency by replacing with Darwin (macOS) or Glibc (Linux), and providing a custom
String(format:...) constructor with one that is based on vsnprintf.

Originally used vasprintf per example code found in Apple doc, but Swift does not find this function in glibc.

How Has This Been Tested?

All existing tests pass, including testOutputPercentileDistributionPlainText which exercises the replacement function.

Minimal checklist:

  • [ X] I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@bradhowes bradhowes changed the title Removed dependency on Foundation feat: Removed dependency on Foundation Apr 15, 2024
@hassila hassila requested a review from dimlio June 20, 2024 17:51
@hassila
Copy link
Contributor

hassila commented Sep 7, 2024

Ping @dimlio

Copy link
Collaborator

@dimlio dimlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me.

For some reason CI on macOS is failing (compiler crashed?!) but it build fine on my box (with Swift 6.0.2).

@dimlio dimlio enabled auto-merge (squash) November 7, 2024 10:20
@dimlio dimlio disabled auto-merge November 7, 2024 10:20
@dimlio dimlio merged commit d8439b8 into HdrHistogram:main Nov 7, 2024
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants