New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed EOut/Eover window events for JS target #1084

Open

deepnight wants to merge 1 commit into HeapsIO:master from deepnight:jsMouseLeaveEvent

Contributor

deepnight commented Jul 7, 2022

Issue: current onMouseLeave() method fires an EReleaseOutside event to targets, which is inconsistent:

the button value is always zero, no matter if the user "left" the canvas with a mouse button pressed or not.
the expected event should be EOut here.

Fix:

replaced the previously not working EReleaseOutside with EOut
added an onMouseEnter callback as well to support EOver


          Fixed EOut/Eover window events for JS target

5a09886

Member

ncannasse commented Jul 8, 2022

What about EReleaseOutside if a EPush was triggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet