Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐭 Update TiledMapLayer Object definition to include height and width. #1222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxbaylee
Copy link

@mxbaylee mxbaylee commented Jul 11, 2024

In the Tiled output I got locally, I got an object similar to this, where height and width are inaccessible due to the type definition here.

{
                 "height":63.7613636363636,
                 "id":8,
                 "name":"",
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":15.6306818181818,
                 "x":32.1846590909091,
                 "y":48.1193181818182
                },

In the Tiled output I got locally, I got an object smilar to this, where height and width are inaccessible due to the type definition here.
```
{
                 "height":63.7613636363636,
                 "id":8,
                 "name":"",
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":15.6306818181818,
                 "x":32.1846590909091,
                 "y":48.1193181818182
                },
```
mxbaylee added a commit to mxbaylee/dungeon-crawler that referenced this pull request Jul 11, 2024
@Yanrishatum
Copy link
Contributor

On contrary I would propose removing that horrid Tiled support outright with very simple reasoning:
It's based on an extremely outdated version of Tiled, missing more than half of the features modern Tiled offers today. It confuses people to use it, instead of better dedicated libraries, and then stumble onto issues like that almost instantly. Community response was and always will be - do not use it.
And my PR of at least adding optional integration to said libraries with #if was dismissed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants