Settings saved in local storage #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in ability to retrieve settings from localstore and to save to localstore when saving in the settings drawer
|
There are some changes in the PR #162 which will require making changes in this to allow the contract address to be saved in the storage. |
dan1elhughes
approved these changes
Dec 17, 2018
ShaunBulbrook
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding in new utility localStore a wrapper around localStorage. settings are now retrieved from localStore, if no settings found then falls back to env variables. any changes made in the settings drawer will save through localStore into the local storage.
Issues fixed
Fixes #161
Checklist
npm testreturns no warnings or errors.