-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for saveWebClientState, postMovie, and postScreenshot #390
Merged
dgarciabriseno
merged 17 commits into
Helioviewer-Project:main
from
dgarciabriseno:json-validate
Jun 20, 2024
Merged
Add validation for saveWebClientState, postMovie, and postScreenshot #390
dgarciabriseno
merged 17 commits into
Helioviewer-Project:main
from
dgarciabriseno:json-validate
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudhoney
reviewed
Jun 18, 2024
dgarciabriseno
commented
Jun 18, 2024
dgarciabriseno
commented
Jun 18, 2024
dgarciabriseno
commented
Jun 18, 2024
dgarciabriseno
commented
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a json schema validator to strictly validate the contents of the web client state being saved, and validate the given arguments for postMovie and postScreenshot.
This is implemented via a new "schema" validator on the existing InputValidator.
JSON schemas should be placed in the
management/schema
and then copied todocroot/schema
viamanagement/schema/deploy.sh
.management/schema
may contain template parameters populated by the database.docroot/schema
are final schema files that may be accessed globally by any json schema validator (not only helioviewer).To validate a json field, the input to the validator looks like this:
Where the first
schema
key tells the validator to use the schema validator, and the second array is in the forminput_parameter_key => schema_file
.