Fix get observation date videos #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added exceptions for functions that can't be called before the movie is processed. added tests
dgarciabriseno
commented
Jul 16, 2024
dgarciabriseno
commented
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Helioviewer-Project/helioviewer.org#580
Among other things, this removes the call to
_getTimeStampswhen aHelioviewerMovieinstance is created, which is a long process. This improves the speed ofgetObservationDateVideossubstantially which will unblock sunlab's minimal view.The other things:
MovieNotCompletedExceptionto theHelioviewerMovieclass which is thrown in functions that only work after a movie has been processed. Some things like the number of frames, the movie's title, and the movie's length are only known after the movie has been processed.HelioviewerMoviewhich tests the new exception cases, that are still built successfully, and that the details provided after building the movie are correct.count(id)tocount(*)since it appears to greatly improve the query speed.