Set THEME_DARK as default to align with default selection of Colors (Dark) #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused. According to |
Yes. I have set night mode on my phone (Android 13 (One UI 5.1)). So with fresh install, auto day/night is already toggled ON and Dark theme appears to be selected in Colors (night). But actually Darker theme is effective. This PR fixes this. |
RHJihan
added a commit
to OishikStudio/Oishik-Keyboard
that referenced
this pull request
Apr 6, 2024
RHJihan
added a commit
to OishikStudio/Probhat-Keyboard
that referenced
this pull request
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THEME_DARK is the first on the list of COLORS_DARK for material, so it is selected by default. Now, the default theme will match the untweaked Colors (Dark) selection.