Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Russian (Student) layout #640

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Zolax9
Copy link
Contributor

@Zolax9 Zolax9 commented Apr 4, 2024

#573
adds a variant of the Russian layout that is used in GBoard and other keyboards for learners of the Russian language (more info and screenshots in the mentioned issue). please review the commit as I'm not entirely sure if I've implemented it correctly!

many thanks!

E̶D̶I̶T̶:̶ ̶̶̶d̶o̶ ̶n̶o̶t̶ ̶m̶e̶r̶g̶e̶ ̶y̶e̶t̶̶̶ ̶a̶s̶ ̶t̶h̶e̶r̶e̶ ̶i̶s̶ ̶a̶n̶ ̶i̶s̶s̶u̶e̶ ̶w̶i̶t̶h̶ ̶o̶n̶e̶ ̶o̶f̶ ̶t̶h̶e̶ ̶l̶e̶t̶t̶e̶r̶s̶ ̶i̶n̶ ̶t̶h̶e̶ ̶l̶a̶y̶o̶u̶t̶ ̶b̶e̶i̶n̶g̶ ̶d̶i̶s̶c̶u̶s̶s̶e̶d̶ ̶i̶n̶ ̶t̶h̶e̶ ̶r̶e̶l̶a̶t̶e̶d̶ ̶i̶s̶s̶u̶e̶.̶

EDIT2: the issue has been fixed and the layout name was changed from "Russian (Students)" to "Russian (Student)" as a better translation of the layout's name derived from GBoard

@Zolax9 Zolax9 changed the title add russian (students) layout add Russian (Students) layout Apr 4, 2024
@Zolax9 Zolax9 force-pushed the russian-students-layout branch 3 times, most recently from a67eb47 to 2e9067e Compare April 4, 2024 20:38
@Zolax9 Zolax9 changed the title add Russian (Students) layout add Russian (Student) layout Apr 4, 2024
@Helium314
Copy link
Owner

The subtypeId must be unique, see layouts.md.

Further, is it necessary to have the popup keys for е and ь?

Otherwise it should be good.

@Zolax9
Copy link
Contributor Author

Zolax9 commented Apr 5, 2024

The subtypeId must be unique, see layouts.md.

oh, my bad. changed to a unique hex number

Further, is it necessary to have the popup keys for е and ь?

I was not aware that they were already pop-up keys for the Russian language. thanks, fixed as well!

@Helium314 Helium314 merged commit 231ffed into Helium314:main Apr 5, 2024
1 check passed
@Zolax9 Zolax9 deleted the russian-students-layout branch April 5, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants