Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mansi layout #791

Merged
merged 4 commits into from
May 17, 2024
Merged

Add Mansi layout #791

merged 4 commits into from
May 17, 2024

Conversation

tenextractor
Copy link
Contributor

@tenextractor tenextractor commented May 15, 2024

See the contributing section in the readme for more detailed guideline: https://github.com/Helium314/HeliBoard?tab=readme-ov-file#guidelines
tl;dr (you should still read the full list though):

  • make sure it's wanted
  • a single thing only
  • describe it properly
  • re-use existing mechanisms / code
  • low performance impact
  • make it a draft if you still want to work on it
  • don't do translation PRs

Further

  • When the PR contains "fixes" , the related issue will be linked and automatically closed if the PR is merged (also works for other words like "fix", "resolve", "resolves", "closes", ...)
  • If you add a keyboard layout, make sure you have read https://github.com/Helium314/HeliBoard/blob/main/layouts.md#adding-new-layouts--languages
  • Please avoid force-pushing when doing changes. This way it's not possible which parts have changed since the previous state.

Add (Northern, but can also be used to type Western) Mansi layout. Partial fix for #762
There is an issue, the language name is shown as 'mns' in the language selection screen and the spacebar, despite adding a string for subtype_mns.
image
Is there any way to fix this? The Kaitag language option shows up just fine.

@tenextractor
Copy link
Contributor Author

image

@Helium314
Copy link
Owner

The Kaitag language option shows up just fine

See the Kaitag PR: https://github.com/Helium314/HeliBoard/pull/519/files#diff-ceae6d63409703480a59c2cc7a80ba68782ef01acc56df9aca17be9d617bf68b
It should work once you add a string resource for subtype_mns.

@tenextractor tenextractor marked this pull request as ready for review May 16, 2024 07:43
@tenextractor
Copy link
Contributor Author

Thanks for the help, it works now

@Helium314 Helium314 merged commit e54d816 into Helium314:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants