Use menu for topic selection

Sources/FeedbackSwift/FeedbackViewController.swift

@@ -52,7 +52,6 @@ open class FeedbackViewController: UITableViewController {
 
         wireframe = FeedbackWireframe(
             viewController: self,
-            transitioningDelegate: self,
             imagePickerDelegate: self,
             mailComposerDelegate: self
         )
@@ -134,8 +133,6 @@ extension FeedbackViewController {
     public override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
         let item = configuration.dataSource.section(at: indexPath.section)[indexPath.row]
         switch item {
-        case _ as TopicItem:
-            wireframe.showTopicsView(with: feedbackEditingService)
         case _ as AttachmentItem:
             guard let cell = tableView.cellForRow(at: indexPath) else {
                 fatalError("Can't get cell")
@@ -191,6 +188,12 @@ extension FeedbackViewController: BodyCellEventProtocol {
     }
 }
 
+extension FeedbackViewController: TopicCellProtocol {
+    func topicCellOptionChanged(_ option: TopicProtocol) {
+        feedbackEditingService.update(selectedTopic: option)
+    }
+}
+
 extension FeedbackViewController: AttachmentCellEventProtocol {
     func showImage(of item: AttachmentItem) {
         // Pending
@@ -320,13 +323,3 @@ extension FeedbackViewController: MFMailComposeViewControllerDelegate {
         mailComposeDelegate?.mailComposeController?(controller, didFinishWith: result, error: error)
     }
 }
-
-extension FeedbackViewController: UIViewControllerTransitioningDelegate {
-    public func presentationController(
-        forPresented presented: UIViewController,
-        presenting: UIViewController?,
-        source: UIViewController
-    ) -> UIPresentationController? {
-        DrawUpPresentationController(presentedViewController: presented, presenting: presenting)
-    }
-}

Sources/FeedbackSwift/FeedbackWireframe.swift

@@ -9,7 +9,6 @@ import UIKit
 import UniformTypeIdentifiers
 
 protocol FeedbackWireframeProtocol {
-    func showTopicsView(with service: FeedbackEditingServiceProtocol)
     func showMailComposer(with feedback: Feedback)
     func showAttachmentActionSheet(
         cellRect: CGRect,
@@ -26,31 +25,21 @@ protocol FeedbackWireframeProtocol {
 
 final class FeedbackWireframe {
     private weak var viewController: UIViewController?
-    private weak var transitioningDelegate: UIViewControllerTransitioningDelegate?
     private weak var imagePickerDelegate: (UIImagePickerControllerDelegate & UINavigationControllerDelegate)?
     private weak var mailComposerDelegate: MFMailComposeViewControllerDelegate?
 
     init(
         viewController: UIViewController,
-        transitioningDelegate: UIViewControllerTransitioningDelegate,
         imagePickerDelegate: UIImagePickerControllerDelegate & UINavigationControllerDelegate,
         mailComposerDelegate: MFMailComposeViewControllerDelegate
     ) {
         self.viewController = viewController
-        self.transitioningDelegate = transitioningDelegate
         self.imagePickerDelegate = imagePickerDelegate
         self.mailComposerDelegate = mailComposerDelegate
     }
 }
 
 extension FeedbackWireframe: FeedbackWireframeProtocol {
-    func showTopicsView(with service: FeedbackEditingServiceProtocol) {
-        let controller = TopicsViewController(service: service)
-        controller.modalPresentationStyle = .custom
-        controller.transitioningDelegate = transitioningDelegate
-
-        DispatchQueue.main.async { self.viewController?.present(controller, animated: true) }
-    }
 
     func showMailComposer(with feedback: Feedback) {
         guard MFMailComposeViewController.canSendMail() else { return showMailConfigurationError() }

Sources/FeedbackSwift/Items/Topic/TopicCell.swift

@@ -5,13 +5,27 @@
 
 import UIKit
 
+protocol TopicCellProtocol {
+    func topicCellOptionChanged(_ option: TopicProtocol)
+}
+
 final public class TopicCell: UITableViewCell {
+    private let button: UIButton = .init(type: .system)
+
     public override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
         super.init(style: .value1, reuseIdentifier: TopicCell.reuseIdentifier)
+        commonInit()
     }
 
     public required init?(coder aDecoder: NSCoder) {
         super.init(coder: aDecoder)
+        commonInit()
+    }
+
+    private func commonInit() {
+        button.titleLabel?.font = .preferredFont(forTextStyle: .body)
+        button.showsMenuAsPrimaryAction = true
+        accessoryView = button
     }
 }
 
@@ -20,11 +34,18 @@ extension TopicCell: CellFactoryProtocol {
         _ cell: TopicCell,
         with item: TopicItem,
         for indexPath: IndexPath,
-        eventHandler: Any?
+        eventHandler: TopicCellProtocol?
     ) {
         cell.textLabel?.text = localized("feedback.Topic")
-        cell.detailTextLabel?.text = item.topicTitle
-        cell.accessoryType = .disclosureIndicator
+        cell.button.setTitle(item.topicTitle, for: .normal)
+        cell.button.menu = .init(
+            children: item.topics.map { topic in
+                UIAction(title: topic.localizedTitle) { action in
+                    eventHandler?.topicCellOptionChanged(topic)
+                }
+            }
+        )
+        cell.button.sizeToFit()
         cell.selectionStyle = .none
     }
 }