Fixes to itemlink and fixes/improvements to CI #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"mysql56" is not (no longer?) a valid service
debian:unstable doesn't have clang-13 available for installation, using debian bookworm instead
pushing a new commit in a PR now stops actions from previous commits of the same PR, allowing CI to stop testing old code and starting the new one earlier
one of the cards used in the test is not available for pre-re, changing to a card that is available in both
guilherme-gm
commented
Oct 19, 2023
guilherme-gm
changed the title
MishimaHaruna
approved these changes
Oct 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This applies some changes to our actions that should make most of them now pass.
AppVeyor doesn't have "mysql56" anymore. I changed to "mysql" (following their docs)
Fixed clang-13 build
The package was never found. I am not skilled in linux packages nor actions, but per my understanding,
debian:unstableno longer has clang-13 (checked here: https://pkgs.org/search/?q=clang ). I changed build pipeline (which includes clang-13) to usedebian:bookworminstead. I don't know if we really need to use unstable here...Added concurrency settings to actions so they now stop the current CI of a PR if a new commit is pushed to this PR.
I have followed these docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency and from my tests everything seems fine
With those changes I expect to have most checks passing, MySQL will continue failing because of
MYSQL_OPT_RECONNECTdeprecation. We use it and this generates a Warning, failing the CI. I am unsure how to better approach this one... I am open to suggestions (and I can work in a separate PR for that).https://dev.mysql.com/doc/c-api/8.0/en/c-api-auto-reconnect.html
Finally, fixing these has shown a few errors in the CI. Some were caused by me 😅 in #3236 , so I am fixing here. Another one was in tests, I fixed it too (hopefully the right way).
Edit: now that all checks finished running.
Issues addressed:
None, I think