Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable attaching scripts to characters in autotrade #3243

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Oct 30, 2023

Pull Request Prelude

Changes Proposed

Disallow using the command attachrid with RIDs from characters in autotrade, as the stack is empty and may crash the server.
Additionally, inform the user of what went wrong when trying to attach such RID.

Issues addressed:
#568

@csnv csnv changed the base branch from stable to master October 30, 2023 00:50
@MishimaHaruna MishimaHaruna added this to the Release v2023.11 milestone Nov 19, 2023
@MishimaHaruna MishimaHaruna merged commit ed2c554 into HerculesWS:master Nov 20, 2023
238 of 255 checks passed
@csnv csnv deleted the fix/attachrid-autoloot branch January 19, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants