Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script commands to generate some client <TAGS> #3300

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

guilherme-gm
Copy link
Member

Pull Request Prelude

Changes Proposed

This PR adds some script commands which generates strings for client tags:

  • mesnavigation: General purpose command for <NAVI>;
  • mesmobspawn: Special command for <NAVI> that opens a window "searching" for a monster -- This is a special behavior in navigation
  • mesurl: For <URL> tag
  • mestipbox: For <TIPBOX> tag

Using those commands takes into account client support and tries to fall back to some sensible results when something is not supported.

I decided to make them as script commands instead of Global Functions because:

  1. We keep client-specific logic into clif -- I feel like this is too client specific to be handled by scripts
  2. We can eventually use these from source directly if there is a need

Issues addressed: None, I think

Comment on lines +2655 to +2656
- NAV_MODE_MAP (1): "You have reached the target map"
- NAV_MODE_NPC (2): "You have reached the map the NPC is at" / "You have reached the target NPC"
Copy link
Member Author

@guilherme-gm guilherme-gm Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about making a mesmapnavi("label", "mapname") and mesnpcnavi("NPC Name"{, "label"}) which could check whether map or npc exists. But I don't remember seeing those being used in official scripts... so I am not sure if it is worth it.

@guilherme-gm guilherme-gm changed the base branch from stable to master June 8, 2024 18:42
@MishimaHaruna MishimaHaruna added this to the Release v2024.06 milestone Jun 30, 2024
@MishimaHaruna MishimaHaruna merged commit 95e65df into HerculesWS:master Jun 30, 2024
346 checks passed
@guilherme-gm guilherme-gm deleted the tags-scriptcmd branch June 30, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants