Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert internal representations to floating point values #111

Closed
joehandzik opened this issue Jul 25, 2017 · 1 comment
Closed

Convert internal representations to floating point values #111

joehandzik opened this issue Jul 25, 2017 · 1 comment

Comments

@joehandzik
Copy link
Contributor

As pointed out in issue #110, there are still cases where we haven't seen non-whole number outputs where we still could see them. So, we should rewrite as much of the internal code as possible to be floating point right off the bat, instead of converting later for Prometheus.
joehandzik pushed a commit that referenced this issue Jul 25, 2017
Use float64 instead of uint64 for all Prom metrics
9828402 
For any possible metric value, always assume the value could require being parsed as a floating point value. This has the positive side-effect of eliminating some conversions to float64 across the codebase.

Fixes issue #111.

Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
@joehandzik joehandzik mentioned this issue Jul 25, 2017
Merged
@roclark
Copy link
Contributor

roclark commented Jul 25, 2017

Fixed with the merging of #112

@roclark roclark closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joehandzik @roclark