Flatten 'stats' map and simplify 'stats' logic #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'stats' map was inefficient and confuscated in its original form. This refactor flattens the map for easier unravelling, while also improving the performance of the collector by removing the nested loops in 'parseFile'. Additionally, this change allows for future potential scalability if the 'stats' map ever needs to be expanded. The logical structure of the map can now stay unchanged without impacting other code snippets. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
roclark
force-pushed
the
refactor-stats-map
branch
from
6c21780
to
d16e816
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'stats' map was inefficient and confuscated in its original form. This refactor flattens the map for easier unravelling, while also improving the performance of the collector by removing the nested loops in 'parseFile'. Additionally, this change allows for future potential scalability if the 'stats' map ever needs to be expanded. The logical structure of the map can now stay unchanged without impacting other code snippets.
Signed-Off-By: Robert Clark robert.d.clark@hpe.com