Support Kingpin and improve help text #121
Conversation
Previously used the default "flags" library, but switched to Kinpin v2 to conform to Prometheus community choice. Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
There was a problem hiding this comment.
LGTM! I will wait to merge in case @mjtrangoni has any comments.
|
Nice work! Thanks! |
Use the enum functionality of Kingpin v2 to enforce valid options for the collector.* flags, and update the help text to clarify what those valid options are. Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
joehandzik
force-pushed
the
wip-kingpin-and-helptext
branch
from
3b13049
to
2c096a5
Compare
|
@mjtrangoni I just made the ordering tweak that you requested. The gotcha here is that the help flag always comes first in the flag list, so I can't alphabetize all flags. I decided to put --help and --version together at the top of the list, (they fit together logically to me, since they don't actually result in a running exporter) and have the rest of the flags together for the rest of the list. |
|
Hi @joehandzik , Thanks! I find the '--help-man' option really cool too! You can create a manual on the fly. |
|
@mjtrangoni I thought it was a nice addition too. Kingpin was pretty much a drop-in replacement with some nice extra features, so thanks for motivating me to get it into our exporter. |
This PR has two commits in it. The first commit adds support for Kingpin v2 and adds it to our vendor directory. The second commit switches the collector.* flags to use the Enum capability of Kingpin, which has the added benefit of filtering out invalid options. We also list out the valid options in the default helptext (though attempting to use an invalid option will result in the valid options being pushed to stdout as well).
This fixes #119 and fixes #120