Reduce redundant code #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
joehandzik
reviewed
May 1, 2017
sources/procfs.go
Outdated
| jobs := jobRegex.FindAllString(jobStats, -1) | ||
| if len(jobs) == 0 { | ||
| jobs := regexCaptureStrings("(?ms:job_id:.*?(-|\\z))", jobStats) | ||
| if len(jobs) < 0 { |
There was a problem hiding this comment.
You're no longer returning nil, nil in cases where len(jobs) is equal to zero. Is that intentional?
There was a problem hiding this comment.
Great catch, this was supposed to be
if len(jobs) < 1 {
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
roclark
force-pushed
the
reduce-redundancies
branch
from
e220c1e
to
e73ead5
Compare
|
@roclark I don't see any other issues. My only concern is sort of an overarching concern with the whole refactor...is it an issue that there are very few cases where you're returning an error struct (almost everything is nil, nil)? If that's intentional and you don't think it'll cause problems, feel free to merge when you're ready. |
|
Due to the conversion of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.