Refactor metric initialization to use structs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run 'gofmt -s -w sources/procfs.go' to clean up a bit and maintain our A+. ;P |
added 2 commits
May 1, 2017 15:46
Replace the nested maps with structs in the metric initializations in order to directly manipulate elements such as the Prometheus name and the file location. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Metric names can now be easily changed by updating the 'promName' value in the lustreHelpStruct definition for every metric. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
roclark
force-pushed
the
struct-metric-list
branch
from
086e41d
to
be8522c
Compare
joehandzik
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now able to directly access metric elements and easily specify a unique Prometheus name at initialization.
Note that I have not yet updated the names to be Prometheus compliant.