Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing md_stats #66

Merged
merged 1 commit into from
May 15, 2017
Merged

Add missing md_stats #66

merged 1 commit into from
May 15, 2017

Conversation

joehandzik
Copy link
Contributor

Fixes issue #62.

Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com

Fixes issue #62.

Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
@joehandzik joehandzik requested a review from roclark May 15, 2017 20:03
@joehandzik
Copy link
Contributor Author

joehandzik commented May 15, 2017

@knweiss, would appreciate it if you took a look too, just to make sure all the metrics you are missing are accounted for.

Copy link
Contributor

@roclark roclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the help text constants (mknodHelp, linkHelp, unlinkHelp...) should actually be declared up above with the desired help text. They are used further below to connect the variable with the intended parsing scheme. Also, these variables should be added to the map on lines 452-483 with an index value of 0 as these all will use the first numerical value on the line.

Copy link
Contributor

@roclark roclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch my last review - I didn't realize these were already added. Looks good to me now!

@knweiss
Copy link

knweiss commented May 15, 2017

Yes, I think the md_stats are complete now:

lustre-release (master) $ git grep LPROC_MDT_|grep 'lprocfs_counter_init('
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_OPEN, 0, "open", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_CLOSE, 0, "close", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_MKNOD, 0, "mknod", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_LINK, 0, "link", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_UNLINK, 0, "unlink", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_MKDIR, 0, "mkdir", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_RMDIR, 0, "rmdir", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_RENAME, 0, "rename", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_GETATTR, 0, "getattr", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_SETATTR, 0, "setattr", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_GETXATTR, 0, "getxattr", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_SETXATTR, 0, "setxattr", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_STATFS, 0, "statfs", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_SYNC, 0, "sync", "reqs");
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_SAMEDIR_RENAME, 0,
lustre/mdt/mdt_lproc.c:        lprocfs_counter_init(stats, LPROC_MDT_CROSSDIR_RENAME, 0,
lustre-release (master) $ git grep LPROC_MDT_|grep 'lprocfs_counter_init('|wc -l
      16

@joehandzik joehandzik merged commit 56cacf6 into master May 15, 2017
@joehandzik joehandzik deleted the wip-fix-missing-mdt-stats branch May 15, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants