Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #74

Merged
merged 4 commits into from
May 17, 2017
Merged

Add unit tests #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd2ba55
Add unit tests
May 12, 2017
78f1b98
Add jobstats integration tests
May 16, 2017
960bb10
Add brw_stats integration tests
May 17, 2017
38dc0e9
Add stats integration tests
May 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 149 additions & 0 deletions sources/brw_stats_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
// (C) Copyright 2017 Hewlett Packard Enterprise Development LP
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package sources

import (
"errors"
"reflect"
"testing"
)

const (
testPagesPerBulkRW string = `pages per bulk r/w rpcs % cum % | rpcs % cum %
1: 14 53 53 | 0 0 0
2: 12 46 100 | 0 0 0`
testDiscontiguousPages string = `discontiguous pages rpcs % cum % | rpcs % cum %
0: 26 100 100 | 0 0 0
1: 0 0 100 | 0 0 0`
testDiskIOsInFlight string = `disk I/Os in flight ios % cum % | ios % cum %
1: 26 100 100 | 0 0 0
2: 0 0 100 | 0 0 0`
testIOTime string = `I/O time (1/1000s) ios % cum % | ios % cum %
1: 2 50 50 | 0 0 0
2: 0 0 50 | 0 0 0
4: 0 0 50 | 0 0 0
8: 0 0 50 | 0 0 0
16: 0 0 50 | 0 0 0
32: 2 50 100 | 0 0 0`
testDiskIOSize string = `disk I/O size ios % cum % | ios % cum %
8: 4 15 15 | 0 0 0
16: 0 0 15 | 0 0 0
32: 1 3 19 | 0 0 0
64: 1 3 23 | 0 0 0
128: 2 7 30 | 0 0 0
256: 1 3 34 | 0 0 0
512: 1 3 38 | 0 0 0
1K: 2 7 46 | 0 0 0
2K: 0 0 46 | 0 0 0
4K: 0 0 46 | 0 0 0
8K: 14 53 100 | 0 0 0`
)

func compareBRWMetrics(expectedMetrics []lustreBRWMetric, parsedMetric lustreBRWMetric) error {
for _, metric := range expectedMetrics {
if reflect.DeepEqual(metric, parsedMetric) {
return nil
}
}
return errors.New("Metric not found")
}

func TestBRWStatsIntegration(t *testing.T) {
numExpectedMetrics := 0
numParsedMetrics := 0
brwSections := map[string]string{
"pages per bulk r/w": testPagesPerBulkRW,
"discontiguous pages": testDiscontiguousPages,
"disk I/Os in flight": testDiskIOsInFlight,
"I/O time (1/1000s)": testIOTime,
"disk I/O size": testDiskIOSize,
}
expectedMetrics := map[string][]lustreBRWMetric{
"pages per bulk r/w": {
{"1", "read", "14"},
{"2", "read", "12"},
{"1", "write", "0"},
{"2", "write", "0"},
},
"discontiguous pages": {
{"0", "read", "26"},
{"1", "read", "0"},
{"0", "write", "0"},
{"1", "write", "0"},
},
"disk I/Os in flight": {
{"1", "read", "26"},
{"2", "read", "0"},
{"1", "write", "0"},
{"2", "write", "0"},
},
"I/O time (1/1000s)": {
{"1", "read", "2"},
{"2", "read", "0"},
{"4", "read", "0"},
{"8", "read", "0"},
{"16", "read", "0"},
{"32", "read", "2"},
{"1", "write", "0"},
{"2", "write", "0"},
{"4", "write", "0"},
{"8", "write", "0"},
{"16", "write", "0"},
{"32", "write", "0"},
},
"disk I/O size": {
{"8", "read", "4"},
{"16", "read", "0"},
{"32", "read", "1"},
{"64", "read", "1"},
{"128", "read", "2"},
{"256", "read", "1"},
{"512", "read", "1"},
{"1K", "read", "2"},
{"2K", "read", "0"},
{"4K", "read", "0"},
{"8K", "read", "14"},
{"8", "write", "0"},
{"16", "write", "0"},
{"32", "write", "0"},
{"64", "write", "0"},
{"128", "write", "0"},
{"256", "write", "0"},
{"512", "write", "0"},
{"1K", "write", "0"},
{"2K", "write", "0"},
{"4K", "write", "0"},
{"8K", "write", "0"},
},
}

for sectionTitle, sectionText := range brwSections {
numExpectedMetrics += len(expectedMetrics[sectionTitle])
metricList, err := splitBRWStats(sectionText)
if err != nil {
t.Fatal(err)
}
for _, metric := range metricList {
numParsedMetrics++
metricFound := compareBRWMetrics(expectedMetrics[sectionTitle], metric)
if metricFound != nil {
t.Fatalf("Unexpected result for %s", sectionTitle)
}
}
}

if numExpectedMetrics != numParsedMetrics {
t.Fatalf("Retrieved an unexpected number of metrics. Expected: %d, Got: %d", numExpectedMetrics, numParsedMetrics)
}
}
170 changes: 170 additions & 0 deletions sources/jobstats_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
// (C) Copyright 2017 Hewlett Packard Enterprise Development LP
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package sources

import (
"errors"
"reflect"
"testing"
)

const testJobStats string = `- job_id: 29
snapshot_time: 1493326943
read_bytes: { samples: 212, unit: bytes, min: 1048576, max: 1048576, sum: 15648015 }
write_bytes: { samples: 262, unit: bytes, min: 1048576, max: 1048576, sum: 274726912 }
getattr: { samples: 10, unit: reqs }
setattr: { samples: 9, unit: reqs }
punch: { samples: 1, unit: reqs }
sync: { samples: 0, unit: reqs }
destroy: { samples: 1, unit: reqs }
create: { samples: 56, unit: reqs }
statfs: { samples: 3, unit: reqs }
get_info: { samples: 98, unit: reqs }
set_info: { samples: 47, unit: reqs }
quotactl: { samples: 10, unit: reqs }
- job_id: 30
snapshot_time: 1493326944
read_bytes: { samples: 113, unit: bytes, min: 1048576, max: 1048576, sum: 153153145 }
write_bytes: { samples: 179, unit: bytes, min: 1048576, max: 1048576, sum: 4534065056 }
getattr: { samples: 13, unit: reqs }
setattr: { samples: 8, unit: reqs }
punch: { samples: 0, unit: reqs }
sync: { samples: 0, unit: reqs }
destroy: { samples: 0, unit: reqs }
create: { samples: 0, unit: reqs }
statfs: { samples: 1, unit: reqs }
get_info: { samples: 112, unit: reqs }
set_info: { samples: 1, unit: reqs }
quotactl: { samples: 1, unit: reqs }
- job_id: 31
snapshot_time: 1493326945
read_bytes: { samples: 289, unit: bytes, min: 1048576, max: 1048576, sum: 486460650 }
write_bytes: { samples: 890, unit: bytes, min: 1048576, max: 1048576, sum: 48904865312 }
getattr: { samples: 1, unit: reqs }
setattr: { samples: 1, unit: reqs }
punch: { samples: 10, unit: reqs }
sync: { samples: 9, unit: reqs }
destroy: { samples: 19, unit: reqs }
create: { samples: 54, unit: reqs }
statfs: { samples: 16, unit: reqs }
get_info: { samples: 12, unit: reqs }
set_info: { samples: 15, unit: reqs }
quotactl: { samples: 11, unit: reqs }`

func compareJobStatsMetrics(expectedMetrics []lustreJobsMetric, parsedMetric lustreJobsMetric) error {
for _, metric := range expectedMetrics {
if reflect.DeepEqual(metric, parsedMetric) {
return nil
}
}
return errors.New("Metric not found")
}

func TestJobStatsIntegration(t *testing.T) {
numParsedMetrics := 0
metricsToTest := map[string]string{
"job_read_samples_total": readSamplesHelp,
"job_read_minimum_size_bytes": readMinimumHelp,
"job_read_maximum_size_bytes": readMaximumHelp,
"job_read_bytes_total": readTotalHelp,
"job_write_samples_total": writeSamplesHelp,
"job_write_minimum_size_bytes": writeMinimumHelp,
"job_write_maximum_size_bytes": writeMaximumHelp,
"job_write_bytes_total": writeTotalHelp,
"job_getattr_total": getattrHelp,
"job_setattr_total": setattrHelp,
"job_punch_total": punchHelp,
"job_sync_total": syncHelp,
"job_destroy_total": destroyHelp,
"job_create_total": createHelp,
"job_statfs_total": statfsHelp,
"job_get_info_total": getInfoHelp,
"job_set_info_total": setInfoHelp,
"job_quotactl_total": quotactlHelp,
}
expectedMetrics := []lustreJobsMetric{
{"29", lustreStatsMetric{"job_read_samples_total", readSamplesHelp, 212}},
{"29", lustreStatsMetric{"job_read_minimum_size_bytes", readMinimumHelp, 1048576}},
{"29", lustreStatsMetric{"job_read_maximum_size_bytes", readMaximumHelp, 1048576}},
{"29", lustreStatsMetric{"job_read_bytes_total", readTotalHelp, 15648015}},
{"29", lustreStatsMetric{"job_write_samples_total", writeSamplesHelp, 262}},
{"29", lustreStatsMetric{"job_write_minimum_size_bytes", writeMinimumHelp, 1048576}},
{"29", lustreStatsMetric{"job_write_maximum_size_bytes", writeMaximumHelp, 1048576}},
{"29", lustreStatsMetric{"job_write_bytes_total", writeTotalHelp, 274726912}},
{"29", lustreStatsMetric{"job_getattr_total", getattrHelp, 10}},
{"29", lustreStatsMetric{"job_setattr_total", setattrHelp, 9}},
{"29", lustreStatsMetric{"job_punch_total", punchHelp, 1}},
{"29", lustreStatsMetric{"job_sync_total", syncHelp, 0}},
{"29", lustreStatsMetric{"job_destroy_total", destroyHelp, 1}},
{"29", lustreStatsMetric{"job_create_total", createHelp, 56}},
{"29", lustreStatsMetric{"job_statfs_total", statfsHelp, 3}},
{"29", lustreStatsMetric{"job_get_info_total", getInfoHelp, 98}},
{"29", lustreStatsMetric{"job_set_info_total", setInfoHelp, 47}},
{"29", lustreStatsMetric{"job_quotactl_total", quotactlHelp, 10}},
{"30", lustreStatsMetric{"job_read_samples_total", readSamplesHelp, 113}},
{"30", lustreStatsMetric{"job_read_minimum_size_bytes", readMinimumHelp, 1048576}},
{"30", lustreStatsMetric{"job_read_maximum_size_bytes", readMaximumHelp, 1048576}},
{"30", lustreStatsMetric{"job_read_bytes_total", readTotalHelp, 153153145}},
{"30", lustreStatsMetric{"job_write_samples_total", writeSamplesHelp, 179}},
{"30", lustreStatsMetric{"job_write_minimum_size_bytes", writeMinimumHelp, 1048576}},
{"30", lustreStatsMetric{"job_write_maximum_size_bytes", writeMaximumHelp, 1048576}},
{"30", lustreStatsMetric{"job_write_bytes_total", writeTotalHelp, 4534065056}},
{"30", lustreStatsMetric{"job_getattr_total", getattrHelp, 13}},
{"30", lustreStatsMetric{"job_setattr_total", setattrHelp, 8}},
{"30", lustreStatsMetric{"job_punch_total", punchHelp, 0}},
{"30", lustreStatsMetric{"job_sync_total", syncHelp, 0}},
{"30", lustreStatsMetric{"job_destroy_total", destroyHelp, 0}},
{"30", lustreStatsMetric{"job_create_total", createHelp, 0}},
{"30", lustreStatsMetric{"job_statfs_total", statfsHelp, 1}},
{"30", lustreStatsMetric{"job_get_info_total", getInfoHelp, 112}},
{"30", lustreStatsMetric{"job_set_info_total", setInfoHelp, 1}},
{"30", lustreStatsMetric{"job_quotactl_total", quotactlHelp, 1}},
{"31", lustreStatsMetric{"job_read_samples_total", readSamplesHelp, 289}},
{"31", lustreStatsMetric{"job_read_minimum_size_bytes", readMinimumHelp, 1048576}},
{"31", lustreStatsMetric{"job_read_maximum_size_bytes", readMaximumHelp, 1048576}},
{"31", lustreStatsMetric{"job_read_bytes_total", readTotalHelp, 486460650}},
{"31", lustreStatsMetric{"job_write_samples_total", writeSamplesHelp, 890}},
{"31", lustreStatsMetric{"job_write_minimum_size_bytes", writeMinimumHelp, 1048576}},
{"31", lustreStatsMetric{"job_write_maximum_size_bytes", writeMaximumHelp, 1048576}},
{"31", lustreStatsMetric{"job_write_bytes_total", writeTotalHelp, 48904865312}},
{"31", lustreStatsMetric{"job_getattr_total", getattrHelp, 1}},
{"31", lustreStatsMetric{"job_setattr_total", setattrHelp, 1}},
{"31", lustreStatsMetric{"job_punch_total", punchHelp, 10}},
{"31", lustreStatsMetric{"job_sync_total", syncHelp, 9}},
{"31", lustreStatsMetric{"job_destroy_total", destroyHelp, 19}},
{"31", lustreStatsMetric{"job_create_total", createHelp, 54}},
{"31", lustreStatsMetric{"job_statfs_total", statfsHelp, 16}},
{"31", lustreStatsMetric{"job_get_info_total", getInfoHelp, 12}},
{"31", lustreStatsMetric{"job_set_info_total", setInfoHelp, 15}},
{"31", lustreStatsMetric{"job_quotactl_total", quotactlHelp, 11}},
}

for promName, promHelp := range metricsToTest {
parsedMetrics, err := parseJobStatsText(testJobStats, promName, promHelp)
if err != nil {
t.Fatal(err)
}
for _, metric := range parsedMetrics {
numParsedMetrics++
metricFound := compareJobStatsMetrics(expectedMetrics, metric)
if metricFound != nil {
t.Fatalf("Metric %s was not found", promName)
}
}
}

if l := len(expectedMetrics); l != numParsedMetrics {
t.Fatalf("Retrieved an unexpected number of jobstats. Expected: %d, Got: %d", l, numParsedMetrics)
}
}
Loading