Cleanup errors caught by megacheck #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
roclark
reviewed
May 25, 2017
sources/procfs.go
Outdated
| for _, item := range jobList { | ||
| metricList = append(metricList, item) | ||
| } | ||
| metricList = append(metricList, jobList...) |
There was a problem hiding this comment.
Do we want (need?) to check if jobList is not nil before this line? Say there aren't any jobs in the job_stats file (happens whenever no jobs have been running for a period of time), the for loop on line 611 would have zero iterations and jobList would never be initialized. I'm not sure how the append(...) command handles nil elements. If it handles them gracefully, no issue, otherwise we might want to add a check beforehand.
roclark
reviewed
May 25, 2017
roclark
reviewed
May 25, 2017
| for _, item := range statsList { | ||
| metricList = append(metricList, item) | ||
| } | ||
| metricList = append(metricList, statsList...) |
There was a problem hiding this comment.
See my other comment - we do the opposite here. Might be good to stay consistent.
roclark
reviewed
May 25, 2017
joehandzik
force-pushed
the
wip-fix-megacheck-issues
branch
from
103d19b
to
506fd57
Compare
|
@roclark PR, now with 100% more consistency. |
roclark
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com