Improve lint tests #302
Merged
Improve lint tests #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine 'download' state where it is used.
Some can be ignored, some should be fixed but can be ignored for now.
Make checking typos part of lint tests.
153957
force-pushed
the
testing-updates
branch
from
c9d9a68
to
93941c3
Compare
davidfokkema
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Black would change this from single quotes to double quotes... does ruff have very different style rules?
There was a problem hiding this comment.
Black always prefers/uses double quotes unless you tell it to skip quote normalization, which I did when I applied black.
Ruff allows it to be configured, to tell it which
https://github.com/HiSPARC/publicdb/blob/testing-updates/pyproject.toml#L83-L87
I prefer single quotes, so I chose that.
There was a problem hiding this comment.
Here, too. Double quotes to single quotes?
davidfokkema
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace flake8/black by ruff for code style and formatting.
Add typos for spell checking.
Fix Python tests cleanup by disabling multiprocessing.