Fix dataset plots #404
Merged
Fix dataset plots #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow hours in day to have decimals.
Otherwise specific tests are taken as seed for shuffle.
|
This is really nice! I can understand why you would want 'hours of day' to use floor division but a float value makes sense as well and it fixes the issues with the plots very nicely. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the conversion of timestamps to hour of day by not rounding the values (using integer division).
Also add tests to most templatetags.
Also fix unittest make target when specifying specific tests to prevent it being seen as a SEED for shuffle.
Examples
Barometer:
Singles:
