[Do not merge] Temporarily delete resources for CDK2 upgrade #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for documentation only. Upgrading straight to CDK2 leads to conflicting resources being create. If you are upgrading from a CDK1 version of this repo it is necessary to do the upgrade in two stage: 1. Upgrade most components, except for the conflicting resources which should be deleted in this step by using this modified `egress_backend_stack.py`. 2. Deploy without this change
|
This was deployed as part of the upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for documentation only.
Upgrading straight to CDK2 leads to conflicting resources being created. If you are upgrading from a CDK1 version of this repo it is necessary to do the upgrade in two stages:
egress_backend_stack.py.During testing the SNS swb_egress_topic trigger seemed to break, recreating the subscription fixed it.