Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align nullability of BO Vertrag and COM Vertragsteil with BO4E.NET #297

Merged
merged 4 commits into from
May 28, 2024
Merged

Align nullability of BO Vertrag and COM Vertragsteil with BO4E.NET #297

merged 4 commits into from
May 28, 2024

Conversation

hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein requested a review from a team as a code owner May 7, 2024 04:41
@hf-kklein hf-kklein marked this pull request as draft May 7, 2024 04:41
@hf-kklein
Copy link
Contributor Author

obsoletes #144

@hf-kklein hf-kklein marked this pull request as ready for review May 7, 2024 04:45
GodsBoss
GodsBoss requested changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@GodsBoss GodsBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to leave outcommented code, the rest looks fine to me.

bo/businessobject.go Outdated Show resolved Hide resolved
bo/businessobject.go Outdated Show resolved Hide resolved
hf-kklein and others added 2 commits May 27, 2024 16:58
@hf-kklein @GodsBoss
Update bo/businessobject.go
ead4ad9 
Co-authored-by: Timo Reitz <godsboss@gmx.de>
@hf-kklein @GodsBoss
Update bo/businessobject.go
f9b6aff 
Co-authored-by: Timo Reitz <godsboss@gmx.de>
@hf-kklein hf-kklein requested a review from GodsBoss May 27, 2024 14:58
@hf-kklein hf-kklein self-assigned this May 27, 2024
@hf-kklein hf-kklein merged commit 24ad208 into main May 28, 2024
9 checks passed
@hf-kklein hf-kklein deleted the nullability-vertrag branch May 28, 2024 06:05
@hf-kklein hf-kklein mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodsBoss GodsBoss GodsBoss approved these changes

@TobiasNaethLynqtech TobiasNaethLynqtech Awaiting requested review from TobiasNaethLynqtech

Assignees

@hf-kklein hf-kklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hf-kklein @GodsBoss