workflows/triage: skip for BrewTestBot PRs #9358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?The triage workflow is supposed to skip PRs opened by @BrewTestBot. However, it does not which eventually causes problems because @BrewTestBot tries (and fails) to approve it's own PR. Seen in #9334.
Note: I haven't tested this PR
Based on the GitHub API documentation for getting the authenticated user, the
user
object that is retrieved contains an object with more metadata rather than just the username. To get the username, we can useuser.login
.While I haven't tested this PR, I've done something similar in actions/stale#231. There, I also used
github.users.getAuthenticated()
and then accessed the user's login via.data.login
. Also, lower down in the workflow file, another comparison is made betweenreview.user.login
anduser.login
to filter only @BrewTestBot reviews. From these, I'm reasonably confident in this change.CC: @reitermarkus