-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all remaining casks to sharded subdirectories. #152603
Conversation
The migration of `orka.rb` and then `o*.rb` has worked well without complaint so: let's move everything else, too.
@MikeMcQuaid Do we have any tests ready for this for when new casks are added, or will it be a check that will be carried out manually for now? |
@bevanjkay Given the lack of any issues for |
I'm more worried that nobody spots a PR outside it's sharded directory. |
Good call, that'd be a good basic CI test to add: fail if there's any files (rather than directories) in |
Note that it's "From:" I tried to Should I open an issue about this? |
Yes, please! |
This is needed after Homebrew/homebrew-cask#152603. Fixes https://github.com/orgs/Homebrew/discussions/4704.
This is needed after Homebrew/homebrew-cask#152603. Fixes https://github.com/orgs/Homebrew/discussions/4704.
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
Update to correctly publish casks to homebrew/homebrew-cask based on sharding [1]. [1]: Homebrew/homebrew-cask#152603
The migration of
orka.rb
and theno*.rb
has worked well without complaint so: let's move everything else, too.Homebrew/brew#15847 should be merged shortly after this PR is.