long update command now uses ';' instead of '&&'

[vitorgalvao]

As per #15532.
On hold until #15381.

Decided to go ahead and remove the upgrade part as well, since that will stop being needed.

[Amorymeltzer]

👍

[jawshooah]

I don't think this is necessary once we remove brew upgrade brew-cask. It's probably a good thing to halt early if brew update fails for some reason.

[vitorgalvao]

Normally I’d agree, but this command is the “fix all” we give users, and every part of it should indeed run (there’s no harm in the later commands running if the earlier commands fail).

For a recent example, a user had an issue that look related to a cask, but later was revealed to be likely related to something wrong with a downloaded/cached version.

Had the && command be used to try and resolve this, the problem would have remained (as #15532 reports), but with the ; command, it was indeed solved.

brew update && brew upgrade do make sense being dependent, but the last ones don’t, since the purpose os this command is to be the “magical” fix for most issues.

---

As a tangential reference and a small piece of HBC history, this isn’t the first time we had a fix-most-issues-one-liner we could call “magical”.

[adidalal]

Needs merge conflicts resolved but no longer on hold.

[jawshooah]

Merged in 5e79596.

[vitorgalvao]

Thank you. Was just about to start fixing the conflicts.